search

opengeospatial / ets-wms13

Repository for the Exectutable Test Suite for WMS 1.3.0
Apache License 2.0
2 stars 4 forks source link

GetMap request is not tested for mandatory version parameter #80

Closed dstenger closed 3 years ago

dstenger commented 3 years ago

Specification OGC 06-042 describes in chapter 7.3.3.1 VERSION that the version parameter of a GetMap request is mandatory. Chapter 7.3.4 GetMap response states that an exception shall be returned (HTTP status code is not clear for me).

A service which is accepting a GetMap request without version parameter is currently passing the test suite.

Also, the ATS does not describe such a test: https://opengeospatial.github.io/ets-wms13/wms-1_3_0-ats.html

dstenger commented 3 years ago

When considering the ATS (https://opengeospatial.github.io/ets-wms13/wms-1_3_0-ats.html), this test should be part of 1.6.1 Test case getmap:getmap. However, if this test just inherits the sub tests, we should create a new test module getmap:version and test case getmap:no-version (we could also think of adding more test cases to this module).

@keshav-nangare The first step is to implement the test case getmap:no-version. Please check where it fits best in the ETS. It might be a complete new test. The ATS can be updated later.

keshavnangare commented 3 years ago

I have added a new test as per the discussion. Please find the changes in #83 PR.

dstenger commented 3 years ago

Please also update the ATS in https://github.com/opengeospatial/ets-wms13/blob/master/src/site/resources/wms-1_3_0-ats.html.

keshavnangare commented 3 years ago

I have updated ats file. Please find the changes in the same PR.