search

opengeospatial / geoapi

GeoAPI provides a set of interfaces in programming languages (currently Java and Python) for geospatial applications. The GeoAPI interfaces closely follow OGC specifications, adaptated to match the expectations of programmers.
http://www.geoapi.org
Apache License 2.0
118 stars 38 forks source link

Minor fixes and typos #41

Closed kinow closed 6 years ago

kinow commented 6 years ago

Organized in three separate commits, so that it is easier to drop or edit one of them if necessary.

There are a few methods with typos in the names, but I believe that they should not be renamed for the sake of backward compatibility. Some methods, though, have typos also in the @UML tags. Submitting another PR for that, as I am not sure if that can be changed or not.

desruisseaux commented 6 years ago

Thanks for the fixes! I verified that the typos you identified in Python code exist in the ISO XML schema, from which the Python documentations were copied:

https://github.com/ISO-TC211/XML

Do you wish to submit a pull request to that ISO-TC211 repository? Otherwise I can do it (but it is nice if you appear as the submitter since you are the one who found the typos).

desruisseaux commented 6 years ago

The methods having typo in a name can be renamed if they appear in geoapi-pending module - or actually in any module other than geoapi, which is the only normative one (note: in the restructuring branch, I'm trying to make that clearer). The geoapi-pending module is work in progress to be submitted for standardization only after we consider it ready.

If the typo appears in the geoapi module, it would be unchanged for GeoAPI 3.1 but we can still consider it for GeoAPI 4.0.

kinow commented 6 years ago

Hi @desruisseaux

Do you wish to submit a pull request to that ISO-TC211 repository? Otherwise I can do it (but it is nice if you appear as the submitter since you are the one who found the typos).

I can give it a try tomorrow. Will also look at the typos found again to see if any is in the modules you mentioned.

Thanks!!!

kinow commented 6 years ago

Done @desruisseaux ! https://github.com/ISO-TC211/XML/pull/200

Hopefully I haven't changed unnecessary files (though I'd be happy to fix that).

Thanks