Update DDL - Githubissues

opengeospatial / geopackage-tiled-gridded-coverage

A GeoPackage extension for tiled, gridded coverage data

Apache License 2.0

5 stars 8 forks source link

Update DDL #13

Closed bradh closed 8 years ago

bradh commented 8 years ago

This includes the following changes:

Add formatting to match the main geopackage DDL
Correct tile_matrix_set_name column name in gpkg_2D_gridded_coverage_ancillary table
Add missing data_null and data_missing columns in gpkg_2D_gridded_coverage_ancillary table
Add CONSTRAINT names to more closely match main geopackage DDL and aid debug
Add missing UNIQUE constraint on gpkg_2D_gridded_tile_ancillary table

bradh commented 8 years ago

Any issue?

jyutzler commented 8 years ago

It looks okay to me but we'll review it as a group on the 10th. We had to skip last week's meeting.

cclark1984 commented 8 years ago

These changes look fine to me. However, the GeoPackage spec states "All specified table, view, column, trigger, and constraint name values SHALL be lowercase." therefore we should probably change gpkg_2D_gridded_coverage_ancillary and gpkg_2D_gridded_tile_ancillary to be all lowercase.

bradh commented 8 years ago

https://github.com/opengeospatial/geopackage-elevation/issues/14 to handle the wider changes for table names.