opengeospatial / geoparquet

Specification for storing geospatial vector data (point, line, polygon) in Parquet
https://geoparquet.org
Apache License 2.0
833 stars 57 forks source link

Require status checks to pass before merging #217

Closed kylebarron closed 6 months ago

kylebarron commented 6 months ago

In light of recent CI failures from https://github.com/opengeospatial/geoparquet/pull/214#issuecomment-2107757451, I propose that we enforce status checks to pass before merging. That is, that we check this box in the repo settings:

image

We can have a separate discussion over which CI checks should exist. The current main is failing the trailing-whitespace and end-of-file-fixer checks. These check that there are no tabs or spaces at the end each line (which have no semantic meaning, at least in Markdown or most code languages), and that there is exactly one newline character at the end of the file.

I would argue that these CI checks make a markdown-heavy repository cleaner, and that they should be kept and enforced.

cholmes commented 6 months ago

+1 on requiring status checks. And I'm also happy to have markdown linting to keep it cleaner.

kylebarron commented 6 months ago

We could have more markdown linting if people desired: https://github.com/DavidAnson/markdownlint

Those two pre-commit checks are little things I have on all my repositories, and so I included them when setting up the pre-commit CI initially. https://github.com/opengeospatial/geoparquet/pull/75

m-mohr commented 6 months ago

+1 - the same happened in #206

kylebarron commented 6 months ago

I updated the branch protection rules for main to include the two CI checks. Let me know if anyone has any concerns.

image