opengeospatial / ogc-geosparql

Public Repository for the OGC GeoSPARQL Standards Working Group
71 stars 19 forks source link

numGeometries: description, return type, refer to geometryN #476

Closed VladimirAlexiev closed 4 months ago

VladimirAlexiev commented 6 months ago

numGeometries is defined as

returns the number of geometries of geom.

I think this is too brief and doesn't specify what is the allowed type of geom.

I think it should refer to geof:geometryN

returns the nth geometry of geom if it is a GeometryCollection that is defined in a literal type (such as in the case of a sf:GeometryCollection) or geom if it is a Geometry. This function is not applicable to the type geo:GeometryCollection, as elements in geo:GeometryCollection are not guaranteed to be ordered.

because numGeometries is the maximum N that can be passed to geometryN.

Also, the description:

Finally, the return type should be xsd:integer not xsd:double