search

opengeospatial / ogcapi-environmental-data-retrieval

A Web API that provides a family of lightweight interfaces for accessing Environmental Data resources.
https://ogcapi.ogc.org/edr
Other
59 stars 26 forks source link

test branch protection for automated commits from GitHub Actions #553

Open tomkralidis opened 4 months ago

tomkralidis commented 4 months ago

There are problems with GitHub Actions for the bundle building example.

This may be rooted in branch protection rules causing this issue.

Test unsetting branch protection PR rules.

cc @chris-little @gbuehler @ghobona

tomkralidis commented 4 months ago

As suspected, unsetting "Require a pull request before merging" resulted in success. OpenAPI bundle builds/commits/pushes fine now.

Having said this, we no longer have this setting, but I think we still do want only PRs to update the branch, with 2 approvals.

Options:

  1. Set "Require a pull request before merging" (bundle build fails, approval workflow intact. Only build / push OpenAPI at milestone stages
  2. Unset "Require a pull request before merging" (bundle build passes, approval workflow not intact. Bundle always up to date
  3. other options?

IMO I would propose option 2 (current setting as a result of unsetting) and we keep the PR/2 approval workflow as a SWG rule, even if it is not explicitly set in GitHub.

Thoughts @chris-little @solson-nws @ShaneMill1 @m-burgoyne ?

solson-nws commented 4 months ago

I agree with @tomkralidis on option 2