search

opengeospatial / ogcapi-features

An open standard for querying geospatial information on the web.
https://ogcapi.ogc.org/features
Other
341 stars 85 forks source link

Use of colon in media types ... #759

Open pvretano opened 2 years ago

pvretano commented 2 years ago

From gitter ... @bradh pointed out: "In https://portal.ogc.org/files/99149#mediatypes, is that supposed to be a valid Media Type? I read RFC 6838 as saying it can't contain a : character." If @bradh is correct then we should patch the source documents and update Part 1 accordingly.

cportele commented 2 years ago

The comment is correct, but the issue cannot be solved by fixing Part 1. The issue is in the GML media type registration at IANA (https://www.iana.org/assignments/media-types/application/gml+xml) and that needs to be corrected first along with the OGC copy of it (https://portal.ogc.org/files/?artifact_id=59324).

Interesting that we did not detect this during the media type registration and that the issue was not raised in the IANA Expert Review process.

I am not aware that the parameter has been used outside of OGC, maybe we should simplify/change the "profile" specification to:

"profile": If provided, this parameter indicates the GML profiles that the GML document conforms to. This is consistent with the semantics of a profile as laid out in RFC 6906.

The parameter can also be used to provide protocol-specific operations, such as profile-based content negotiation in HTTP.

Valid profiles are published at http://www.opengis.net/def/profile/ogc/gml. The profiles follow the pattern 'http://www.opengis.net/def/profile/ogc/gml/{name}' where 'name' is the value of the "profile" parameter, e.g., 'gml-sf0'.

As a GML document may conform to more than one GML profile, the parameter SHALL be a whitespace-separated list of profile names.

Note: The original media type specification required the profile names to be URIs. This violates the requirements for media type parameter values, which only allow a restricted character set. Implementations should be updated to support this updated specification of the "profile" parameter.

I also notice that the OGC Definition Server has a problem, both http://www.opengis.net/def/profile/ogc/gml and http://www.opengis.net/def/profile both result in an error. This would need to be fixed before submitting anything to IANA.

@ogcscotts - I am not aware of a form to submit corrections to a registered media type, only new submissions. Are you aware of any other channel to update a media type registration? Any other thoughts?

bradh commented 2 years ago

I think this probably needs to be resolved at the OGC Naming Authority and a common approach pushed out to all applicable documents / SWGs.

See https://github.com/opengeospatial/NamingAuthority/issues/194 for my report.

bradh commented 2 years ago

Looks like the source documents just need it to be quoted.

cportele commented 2 years ago

@bradh - I think the profile parameter values are all quoted. Can you point out where the quotes are missing?

Note: In v1.0.0 the quotes were missing, but that has been corrected in May 2020 (#382) and this fix is part of v1.0.1.

bradh commented 2 years ago

My bad. Possibly I was looking at an older version.

The only places I see without quotes are https://github.com/opengeospatial/ogcapi-features/blob/master/implementations/servers/nlsfi.md and https://github.com/opengeospatial/ogcapi-features/blob/3623485b918727dbe174af6a2aa446b8dd1f620d/implementations/servers/cubewerx.md