search

opengeospatial / ogcapi-processes

https://ogcapi.ogc.org/processes
Other
48 stars 45 forks source link

Proposal OGC API - Processs - Part4: Job Management #437

Closed gfenoy closed 1 month ago

gfenoy commented 2 months ago

Following the discussions during today's GDC / OGC API—Processes SWG meeting, I created this PR.

It contains a proposal for an additional part to the OGC API - Processes family: "OGC API - Processes - Part 4: Job Management" extension.

This extension was initially discussed here:

The document identifier 24-051 was registered.

fmigneault commented 2 months ago

@gfenoy The README should include the URL for the eventual HTML/PDF draft location.

m-mohr commented 2 months ago

I thought I already posted here, but can't find it. I plan to review this to ensure this is compatible/works well with openEO, but I'm currently on vacation and as such the review will probably take another 2-3 weeks, sorry.

m-mohr commented 1 month ago

Is there already a rendered version of this? It's difficult to review as it's so many tiny files and as such the files lack context to me.

fmigneault commented 1 month ago

@gfenoy I've been working on implementing job management, and while looking at the PR to apply a comment, I noticed there is no openapi/paths/pJobs file or similar defining the POST /jobs, or any of the other endpoints added under /jobs/{jobId}/....

gfenoy commented 1 month ago

@gfenoy I've been working on implementing job management, and while looking at the PR to apply a comment, I noticed there is no openapi/paths/pJobs file or similar defining the POST /jobs, or any of the other endpoints added under /jobs/{jobId}/....

Thanks a lot for pointing this out. I have drafted some of these missing files and they are now available from there: https://github.com/GeoLabs/ogcapi-processes/tree/proposal-part4-initial/openapi/paths/processes-job-management.

I would like to stress that I only included the added method and did not include the previous one that should be added.

Maybe we can update the update.sh script later on, to concatenate the files with the same name in the original processes-core directory.

m-mohr commented 1 month ago

@gfenoy What do we do with the unresolved comments in this PR?

gfenoy commented 1 month ago

@m-mohr for unfinished dicussions please use the issue system and tag your issue with Part 4 (Job Management).

We think that it will ease organizing the work and discussions this way.

fmigneault commented 1 month ago

@gfenoy @pvretano @ghobona I don't mind going through the PR and creating the issues, but I do not have enough permissions to apply the labels. Can someone grant me this access?

gfenoy commented 1 month ago

I cannot grant privilege to contributors of this repository.

m-mohr commented 1 month ago

Hmm, okay. I had hoped that if we review a PR at least some of the review comments would be considered and be updated in the PR. Not even typos with actual commitable suggestions were merged. The procedure seems not optimal. Now I need to spam issues copying text that may lack context. But anyway, I opened issues, added a prefix to the title as I can't assign labels.

ghobona commented 1 month ago

The labels appear to have been applied.