opengeospatial / ogcapi-records

An open standard for the discovery of geospatial resources on the Web.
https://ogcapi.ogc.org/records
Other
56 stars 26 forks source link

clarify contact name/organization #294

Closed tomkralidis closed 1 year ago

tomkralidis commented 1 year ago

The current contact schema describes contact name / organization as follows:

  name:
    type: string
    description: |-
      The name of the organization or the individual.
  organization:
    type: string
    description:
      Organization/affiliation of the individual/responsible person. In
      case of an organization, the name property should be used and this
      property is not to be used.

name is a required property.

Is implementing name or organization, then, domain/activity specific? For example, consider a catalogue implementing facets on contact organizations. Would the catalogue have to check if organization exists? If not, then use name and assume name is an organization?

Should we consider a contact to require ~ONE OF~ ANY OF name or organization, with clear definitions of each?

cc @pvretano @kalxas @m-mohr @pvgenuchten

m-mohr commented 1 year ago

I think this is good as it is. name specifies the name of the entity and organization is just use for an individual that is affiliated with a company. But maybe we need to clarify this.

pvgenuchten commented 1 year ago

3 cases could be captured

When using name only, it is impossible to distinguish case 1 from case 2

tomkralidis commented 1 year ago

2023-07-05: agreement to move forward with proposal. I will issue a PR.

m-mohr commented 1 year ago

Above it says "ONE OF" for name and organization. Does this mean you can't provide both name and organization?

tomkralidis commented 1 year ago

Changed to ANY OF

m-mohr commented 1 year ago

~"any of" would mean providing none of them is also fine ;-) I guess what it actually meant here is "at least one of".~

tomkralidis commented 1 year ago

So then:

 "oneOf": [
    {
      "allOf": [
        {
          "required": [
            "name"
          ]
        }
      ]
    },
    {
      "allOf": [
        {
          "required": [
            "organization"
          ]
        }
      ]
    }
  ]
m-mohr commented 1 year ago

Sorry @tomkralidis, my fault, I was mixing things up. any of is correct :-)

tomkralidis commented 1 year ago

PR in #296