opengeospatial / ogcapi-tiles

OGC API - Tiles draft specification
https://ogcapi.ogc.org/tiles
Other
37 stars 18 forks source link

Use the conformance class in the recommendation identifiers #130

Closed tschaub closed 2 years ago

tschaub commented 2 years ago

This updates a number of the permissions and recommendations so that their identifiers include the compliance class (e.g. /rec/core/* for a recommendation in the core.

I also adjusted a few of the block identifiers in the docs - trying to be consistent with existing logic.

Fixes #129.

jerstlouis commented 2 years ago

Thanks for this @tschaub !

tschaub commented 2 years ago

I didn't change anything for any of the requirements. It looks like there might be cases worth changing there, too.

For example, collections appears in part of the datetime requirements: https://github.com/opengeospatial/ogcapi-tiles/blob/bbe51059ca594910dbb9390e40858fdb40a9b1a3/core/standard/api_modules/datetime/requirements/REQ_rc-datetime-definition.adoc#L4

Should these be /req/datetime instead of /req/collections?

jerstlouis commented 2 years ago

@tschaub I think this originates comes from it being an "api module" that we tried to re-use directly, but we may now be leaning towards adapting those API modules / building blocks to the specification / conformance classes where they are used, so I would suggest that the identifiers for the requirements always be consistent with the conformance classes where they are used.

datetime

ghobona commented 2 years ago

@joanma747 @jerstlouis I'm in the process of converting the document to metanorma asciidoc. Please review this PR, approve it, but do not merge it. I will merge the PR after completing the conversion to metanorma asciidoc (in mid September 2022).

joanma747 commented 2 years ago

Done manualy. Thanks