opengeospatial / om-swg

10 stars 6 forks source link

Definition of FeatureType (19109 vs. 19136) #181

Closed KathiSchleidt closed 3 months ago

KathiSchleidt commented 2 years ago

DK11-024 The FeatureType is defined in ISO 19109, not in ISO 19136 (ISO 19136 defines the UML-to-GML encoding rules for an application schema according to ISO 19109). See also Table 17 in ISO 19109:2015. Update the text so that the source of the FeatureType stereotype is correct.

4.2 2nd paragraph

ilkkarinne commented 2 years ago

This text is unchanged from the 2011 version. It does not say that the FeatureType metaclass is defined 19136, but that the stereotype FeatureType is, and there is also a reference to 19109:

The UML in Abstract Core and Basic packages is conformant with the profile described in ISO 19136-1:2020, Annex E. Use of this restricted idiom supports direct transformation into a GML Application Schema. ISO 19136 [28] introduces some additional stereotypes. In particular «FeatureType» implies that a class is an instance of the «metaclass» GF_FeatureType (ISO 19109), and therefore represents a feature type.

However, the reference to GF_FeatureType should be replaced by FeatureType, as this is updated in 19109:2015.

Proposal: no change in text

KathiSchleidt commented 2 years ago

Confused!!! Assuming "no change in text" means leaving the reference to 10109, but updating the «metaclass» GF_FeatureType to FeatureType as done in the following text:

The UML in Abstract Core and Basic packages is conformant with the profile described in ISO 19136 1:2020, Annex E. Use of this restricted idiom supports direct transformation into a GML Application Schema. ISO 19136 introduces some additional stereotypes. In particular «FeatureType» implies that a class is an instance of the «metaclass» FeatureType (ISO 19109), and therefore represents a feature type.

ilkkarinne commented 2 years ago

Thanks @KathiSchleidt, your interpretation of my confusing comment is correct :-)

KathiSchleidt commented 2 years ago

@cportele Is our logic correct here?

cportele commented 2 years ago

@KathiSchleidt

When GML 3.2 / 19136 was written, 19109 did not define a stereotype FeatureType, so originally it was defined in GML 3.2 / 19136. In the 2015 revision 19109 added the stereotype FeatureType to identify classes that are feature types (instances of the metaclass FeatureType in the GFM.

The proposed text is fine, but we could also simplify it to something like:

The UML in Abstract Core and Basic packages is conformant with the profile described in ISO 19136-1:2020, Annex E. Use of this restricted idiom supports direct transformation into a GML Application Schema. The stereotype «FeatureType» states that a class is an instance of the «metaclass» FeatureType (ISO 19109), and therefore represents a feature type.

KathiSchleidt commented 2 years ago

@cportele many thanks! I propose using your proposal!

cportele commented 2 years ago

I think that would also be consistent with the discussion about this in the EC meeting.

ilkkarinne commented 2 years ago

I agree with changing the text to @cportele's suggestion. I think that in this case we can also change the status from "Accepted in principle" to "Accepted". I'll update the comment resolution table accordingly and notify rest of the EC members.