Observation Collection

[KathiSchleidt]

The need for a class for collections of observations, with optional values for all of the observation properties – to support sets of observations that have common values for one or more of procedure, feature-of-interest, observedproperty, phenomenon-time, result-time

Source: TC211 Comments AU001, PMG009

[KathiSchleidt]

9.10.2 AbstractObservationCollectionType moved to 9.10.2, modifed req from obs-basic to obs-core

10.4 ObservationCollection content moved to 9.9 AbstractObservationCollection, modifed reqs from obs-basic to obs-core, modified ObservationCollection to AbstractObservationCollection. Added Note that described in Figure 16 (under 9.9.1)

9.1.1 Abstract Observation Core Package Requirements Class: added Imports /req/obs-core/AbstractObservationCollection

10.4 ObservationCollection updated, only requirement in Req Class is /req/obs-core/AbstractObservationCollection, removed subclauses (all under 9.9)

What did I miss?

[ilkkarinne]

Figures impacted by the change:

• Context diagram for Abstract Observation Core — AbstractObservationCharacteristics and AbstractObservation (Figure 10): Add AbstractObservarionCollection class and the association between AbstractObservationCharacteristics and AbstractObservationCollection.
• Context diagram for Abstract Observation Core — AbstractObservationCollection: new Figure 16
• Context diagram for Basic Observations — Observation: old Figure 16, renumber to Figure 17
• Context diagram for Basic Observations — ObservationCharacteristics, ObservingCapability and ObservationCollection: old Figure 17, renumber to Figure 18, move the AbstractObservationCollection and AbstractObservationCollectionType classes to the Abstract Observation Core package frame
• Rest of the Figures in the document body (old 18-36): shift Figure numbers by one, and update text references
• Figures E.1 and E.2: Move the AbstractObservationCollection and AbstractObservationCollectionType classes to the Abstract Observation Core package frame

[ilkkarinne]

Suggested fixes for requirements text due to changing the collection - memberCharacteristics association from between ObservationCollection and ObservationCharacteristics (in Basic) to between AbstractObservationCollection and AbstractObservationCharacteristics (in Core):

• Requirement /req/obs-core/AbstractObservationCollection/collectionType-con: current text: "If the collectionType is provided, property values of the associated Observation and ObservationCharacteristics instances shall comply with the constraints defined for this collectionType value."; proposed new text: "If the collectionType is provided, property values of the associated Observation and AbstractObservationCharacteristics instances shall comply with the constraints defined for this collectionType value."
• Requirement /req/obs-core/AbstractObservationCollection/memberCharacteristics-sem: current text: "Information on ObservationCharacteristics of Observations contained within the AbstractObservationCollection. If a reference to ObservationCharacteristics pertaining to the collection members is provided, the association with the role memberCharacteristics shall be used."; proposed new text: "Information on AbstractObservationCharacteristics of Observations contained within the AbstractObservationCollection. If a reference to AbstractObservationCharacteristics pertaining to the collection members is provided, the association with the role memberCharacteristics shall be used."
• Requirement /req/obs-basic/ObservationCharacteristics/collection-sem: must be moved to under clause 9.2 AbstractObservationCharacteristics as Requirement /req/obs-core/AbstractObservationCharacteristics/collection-sem, and the text modified from "An ObservationCollection that is described by these ObservationCharacteristics. If a reference to an ObservationCollection from the ObservationCharacteristics is provided, the association with the role collection shall be used." to "An AbstractObservationCollection that is described by these AbstractObservationCharacteristics. If a reference to an AbstractObservationCollection from the AbstractObservationCharacteristics is provided, the association with the role collection shall be used."

[KathiSchleidt]

Done! Also fixed the Req Class tables to account for shifting collection-sem to abstract

[sgrellet]

@KathiSchleidt , @ilkkarinne : while cross-checking there is something that bothers me (pretty sure that was discussed before but I prefer asking)

Why are we traversing abstraction levels ?

• Currently AbstractObservationCollection +member is the Observation
• and not AbstractObservation while +memberCharacteristics are AbstractObservationCharacteristics.

[sgrellet]

Also missing:

• updating Table 2 — Abstract Observation core Core conformance classes and missing the corresponding entry in A.2 Abstract tests for Abstract Observation core Core package : NOT Done
• updating references to in C.8 Generic metadata associations : adding AbstractObservationCollection and removing ObservationCollection : DONE

[KathiSchleidt]

@sgrellet on the traversing levels, think this has to do with the fact that we don't have all OMS FT at the conceptual level (no interface for Collection or Characteristics)

• for +member, the target is Observation, goes to the conceptual interface
• for +memberCharacteristics (as well as its inverse +collection), there's no conceptual interface, so the associations go to the abstractClasses

However, your note on C.8 just created a whole new nightmare for me - we now have an AbstractObservationCollection, but no AbstractSampleCollection (once again proving that we're the first to quietly ignore Samples!!!)

[sgrellet]

@KathiSchleidt : on the traversing levels, your analysis is right. I just fear that other (and esp. newcomers to OMS) may be puzzled by this.

On C.8 : sorry :(

[dr-shorthair]

we now have an AbstractObservationCollection, but no AbstractSampleCollection (once again proving that we're the first to quietly ignore Samples

Part of the challenge here is that we know about ObservationCollection - which is a collection of activities, while SampleCollection is a collection of entities (using Prov-o terminology), and we think less about SamplingCollections (the matching collection of sampling activities).

In practice I have usually found the need for a generic ActivityCollection, which is an umbrella for a set of Observations and Samplings and Treatments (which are a kind of Actuation). Project and SiteVisit are often sub-classes of ActivityCollection.

Probably too generic and too late for OMS, but a bit of perspective.

[sgrellet]

`In practice I have usually found the need for a generic ActivityCollection, which is an umbrella for a set of Observations and Samplings and Treatments (which are a kind of Actuation). Project and SiteVisit are often sub-classes of ActivityCollection. Probably too generic and too late for OMS, but a bit of perspective.'

Thanks Simon for this. I also tried to push for MonitoringAcitivity during the revision process but failed. It was more a collection of Observations & Samplings without Treatments. But when reading your description I now feel adding Treatment/Actuation in the package would make a lot of sense as we also do have equivalent such Activities here. I'll create an issue about to avoid forgetting this part.

[ilkkarinne]

Raising this as to not forget to do it:

• updating Table 2 — Abstract Observation core Core conformance classes and missing the corresponding entry in A.2 Abstract tests for Abstract Observation core Core package : NOT Done

Proposed fixes:

• Add new clause A.2.10 Abstract Observation Core – AbstractObservationCollection with a table for Conformance Class /conf/obs-core/AbstractObservationCollection
• Add a new row in Table 2 — Abstract Observation Core conformance classes for /conf/obs-core/AbstractObservationCollection

[ilkkarinne]

Proposed fixes:

• Add new clause A.2.10 Abstract Observation Core – AbstractObservationCollection with a table for Conformance Class /conf/obs-core/AbstractObservationCollection
• Add a new row in Table 2 — Abstract Observation Core conformance classes for /conf/obs-core/AbstractObservationCollection

These have been added in the Word document with commit 565e9bcda60f02cfafa24ea85bc302828c2e999d

[ilkkarinne]

Cross-checked by @KathiSchleidt, moving into Implementation cross-checked