Closed ferjm closed 2 years ago
The description is indeed not very good. I interpreted it as /$ref being a shorthand for ?$select=@iot.selfLink
The only difference between the example and the SensorUp reference implementation is the added @iot.count. Adding that @iot.count does make sense in respect to the rest of the standard, and would match my interpretation as a shorthand for ?$select=@iot.selfLink. On the other hand, the SensorUp implementation deviates from the described standard in multiple ways, so that doesn't mean much ;)
For change proposals I've downloaded the source of the document using wget, and made a GitHub project with that: https://github.com/hylkevds/SensorThingsAPI Feel free to clone that further :)
Thanks for finding the mistake. It is a minor mistake in the standard document. "url" was used in a very early version of STA. Then the url notation was updated to selfLink, and then updated to @iot.selfLink. Somehow it wasn't updated in this section. Good eye.
Regarding SensorUp's implementation containing @iot.count, it is compliant to the standard. There is no issue here. :)
@taniakhalafbeigi @hylkevds Here is a PR for this issue: https://github.com/opengeospatial/sensorthings/pull/73
Thanks for the PR, looks good.
Fixed with the publication of Sensing v1.1.
http://docs.opengeospatial.org/is/15-078r6/15-078r6.html#41 mentions the following:
Which is not consistent with the example provided in the spec:
First of all, the name of the property in the example is not
url
as described in the definition but@iot.selfLinks
, which also seems incorrect, as it should probably be@iot.selfLink
in singular.Finally, this is also not what the SensorUp reference implementation is returning for these kind of requests. For example, a request to http://scratchpad.sensorup.com/OGCSensorThings/v1.0/Things(29761)/Datastreams/$ref responses with:
Which looks more consistent with what a request to an address to a collection of entities responses.
I would propose the specific changes to the spec document myself, but I can't find its source.