search

opengeospatial / styles-and-symbology

OGC Styles & Symbology Standards
Other
11 stars 6 forks source link

Code formatting CartoSym-JSON.schema.json #44

Closed KaiVolland closed 1 year ago

KaiVolland commented 1 year ago

This formats the CartoSym-JSON.schema.json to use two whitespaces for indentation. It also makes shure to to keep the same structure of linebreaks for objects and arrays.

It also removes a dangling comma (former line 69).

jerstlouis commented 1 year ago

Thanks for the contribution @KaiVolland . At this point since I am hand-editing this in our IDE and generally have a preference for 3 spaces and fewer lines to see more on the screen at the same time, so I prefer to keep the custom formatting. I will try to make it more consistent.

I have merged your fix for the dangling comma. Please keep us up to date on your progress using the schema to generate TypeScript classes etc.!

KaiVolland commented 1 year ago

Currently there is a mix of 3 or 2 whitespaces. Maybe we can improve this to be consistent through the whole file.