openghg / openghg_inversions

University of Bristol Atmospheric Chemistry Research Group RHIME Inversion code (with openghg dependency)
MIT License
5 stars 0 forks source link

Numpyro sampler option, documentation, land/sea map fix, save trace fix #101

Closed brendan-m-murphy closed 2 months ago

brendan-m-murphy commented 2 months ago

This branch adds the option to use Numpyro's NUTS sampler in place of the pymc NUTS sampler. This seems to be 7-10x faster. This addresses issue #17 and the ACRG project issue #30, although profiling needs to be done to assess the speed improvements.

It also adds some documentation by expanding the readme file and adding a short overview (https://github.com/openghg/openghg_inversions/tree/numpyro-fixed-outer-regions)

There are fixes to two other issues as well:

Also, a link to the DOI associated with releases was added to the readme file, and a test was added for the bucket/weighted basis function.

brendan-m-murphy commented 2 months ago

@joe-pitt reports: error using weighted basis with fixed outer regions:

[Yesterday 21:23] Joe Pitt File "/user/home/zh21490/openghg_inversions/openghg_inversions/basis/_functions.py", line 201, in fixed_outer_regions_basis

basis.loc[loc_dict] = (inner_region + 5).squeeze().values

[Yesterday 21:24] Joe Pitt ValueError: could not broadcast input array from shape (183,128) into shape (182,127)