search

openghg / openghg_inversions

University of Bristol Atmospheric Chemistry Research Group RHIME Inversion code (with openghg dependency)
MIT License
5 stars 0 forks source link

Make min_error a minimum value and update README #117

Closed joe-pitt closed 1 month ago

joe-pitt commented 1 month ago

Changed inferpymc so that it interprets min_error as a minimum value (lower bound) rather than adding it to the other errors for all points. This addresses Issue #116 .

Needs looking at by someone who understands pytensors before approval - I'm not certain that what I've done here is correct.

brendan-m-murphy commented 1 month ago

It looks like pt.maximum is what we want: https://pytensor.readthedocs.io/en/latest/library/tensor/basic.html#mathematical We could also achieve this with the switch statement.