ag12733
commented
1 month ago Yes I think Joe is right. We want the inlet to be less than PBLH -50.
Dr. Anita Ganesan Associate Professor School of Geographical Sciences University of Bristol Bristol, BS8 1SS, United Kingdom Tel: +44 117 455 1545
Email: @.**@.> Website: http://aganesan.blogs.bris.ac.ukhttp://aganesan.blogs.ilrt.org/
From: Joe Pitt @.> Date: Monday, 13 May 2024 at 09:55 To: openghg/openghg_inversions @.> Cc: Anita Ganesan @.>, Review requested @.> Subject: Re: [openghg/openghg_inversions] Answer (partial) to issue 118 (PR #119)
@joe-pitt requested changes on this pull request.
Should it not be a < sign in L412? i for i, pblh in enumerate(pblh_da) if inlet_height > pblh - diff_threshold
It would also be good to add the new filters to the docstring (and remove the pblh entry). Otherwise I think this is good.
— Reply to this email directly, view it on GitHubhttps://github.com/openghg/openghg_inversions/pull/119#pullrequestreview-2052091933, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVCIICGYLTDZI5IGKDVPBCDZCB5YZAVCNFSM6AAAAABHQ2VU3CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJSGA4TCOJTGM. You are receiving this because your review was requested.Message ID: @.***>
Add a filter that removes data for which the pblh is below a threshod (e.g. below 200m);
Change the name of the pblh filter (e.g. to pblh_inlet_diff) to clarify it and change the filter so that only data taken more than 50m below the pblh is retained; Add some tests about this.