Fix min_error calculation

openghg / openghg_inversions

University of Bristol Atmospheric Chemistry Research Group RHIME Inversion code (with openghg dependency)

MIT License

5 stars 0 forks source link

Closed hdelongueville closed 3 months ago

hdelongueville commented 3 months ago

Summary of changes The residual error method used to calculate the min error has been fixed to rescale mf_mod to mf units before calculating (y - y_mod).
Please check if the PR fulfills these requirements
[x] Closes #140
[ ] Tests added and passing
[ ] Documentation and tutorials updated/added
[ ] Added an entry to the CHANGELOG.md file
[ ] Added any new requirements to requirements.txt

hdelongueville commented 3 months ago

I did what I could with my python knowledge. Maybe it could use some better coding. I'm open to any suggestion.

hdelongueville commented 3 months ago

The script is failing when use_bc = False because there is no bc_mod to add to mf_mod. The script needs to be modified for cases when use_bc = False.

hdelongueville commented 3 months ago

Great thanks!