Resolve small bugs described in issues #194, #196 and #197.

openghg / openghg_inversions

University of Bristol Atmospheric Chemistry Research Group RHIME Inversion code (with openghg dependency)

MIT License

5 stars 0 forks source link

Resolve small bugs described in issues #194, #196 and #197. #195

Closed alexdanjou closed 3 months ago

alexdanjou commented 3 months ago

Summary of changes
Please check if the PR fulfills these requirements
[x] Closes #194 , #196, #197
[ ] Tests added and passing
[ ] Documentation and tutorials updated/added
[ ] Added an entry to the CHANGELOG.md file
[ ] Added any new requirements to requirements.txt

brendan-m-murphy commented 3 months ago

Refering to issue 194:

In previous version

config_file was defined as

default_config_file = os.path.join(openghginv_path, "hbmcmc/hbmcmc_input.ini")

config_file = default_config_file

and now as

config_file = openghginv_path / "hbmcmc" / "hbmcmc_input.ini"

Could the issue come from here?

The openghginv_path is a Path object, so you can do this notation. If you pass a path via the ini file it isn't converted. I missed that because none of the tests use an ini file.