allowed outer region to include EASTASIA and added region file

openghg / openghg_inversions

University of Bristol Atmospheric Chemistry Research Group RHIME Inversion code (with openghg dependency)

MIT License

5 stars 0 forks source link

allowed outer region to include EASTASIA and added region file #206

Closed qq23840 closed 1 month ago

qq23840 commented 2 months ago

Adds an EASTASIA outer region file and modifies the outer region basis function code to read in any outer region file.

Currently a pretty arbitrary outer region - I will check with Alistair/Alice whether there is an 'official' set of outer regions that InTEM uses, for consistency (hence the draft PR).

Please check if the PR fulfills these requirements
[x] Closes #201
[ ] Tests added and passing
[ ] Documentation and tutorials updated/added
[ ] Added an entry to the CHANGELOG.md file
[ ] Added any new requirements to requirements.txt

brendan-m-murphy commented 2 months ago

Looks good. You could parameterise the test you added by using the decorator @pytest.mark.parametrize("domain", ["EUROPE", "EASTASIA"]) above the test and making domain an argument of the test function. Let me know when you want a review.

qq23840 commented 2 months ago

Have added the official regions from @aliceramsden. To add a test I'd have to generate a load of files, as all the test data is only set up for ch4 / EUROPE at the moment. Maybe a code retreat task rather than an urgent priority?

brendan-m-murphy commented 2 months ago

Have added the official regions from @aliceramsden. To add a test I'd have to generate a load of files, as all the test data is only set up for ch4 / EUROPE at the moment. Maybe a code retreat task rather than an urgent priority?

Ah good point. Yea we can leave it for now. It would be good to be able to test the basis functions without running all of the code in get_data.py (so we could use synthetic data for the flux * fp, say).