search

opengisch / QgisModelBaker

Create QGIS projects from database schemas or Interlis models
https://opengisch.github.io/QgisModelBaker/
GNU Lesser General Public License v3.0
55 stars 17 forks source link

[gui] Remember previous settings when using a PG service #918

Closed gacarrillor closed 5 months ago

gacarrillor commented 5 months ago

What is changed

When opening the dialog, if there is a service stored in QSettings, we set it in the first place (before it was set in the last place), and after that we check for QSettings that complement the PG service settings.

Other details

Note the current PG service definition will take precedence over corresponding stored QSettings.

Also note that SSLMode is not being stored in QSettings (see https://github.com/opengisch/QgisModelBakerLibrary/blob/412e60ccf4a0cf96432470c49d3eb725489626de/modelbaker/db_factory/pg_command_config_manager.py#L149-L173).

PR #96 to the underlying lib fixes that.

Fix #709

signedav commented 5 months ago

Btw. you don't have to use your own fork here (of course you can if you prefer) or do you don't have the correct access rights?

gacarrillor commented 5 months ago

Btw. you don't have to use your own fork here (of course you can if you prefer) or do you don't have the correct access rights?

Good to know, thanks! And yes, I have proper rights in this repo.

Now that you mentioned, I haven't yet proper rights for the lib repo. Could you please grant me the rights?

BTW, will you always do the merges or once approved anyone with rights can click on merge?

signedav commented 5 months ago

Gave you rights for the lib.

Yes. If the PR is approved you are allowed to merge.

gacarrillor commented 5 months ago

Gave you rights for the lib.

Thanks!

Yes. If the PR is approved you are allowed to merge.

Great!