search

opengisch / QgisModelBaker

Create QGIS projects from database schemas or Interlis models
https://opengisch.github.io/QgisModelBaker/
GNU Lesser General Public License v3.0
54 stars 18 forks source link

[export] Include the basket's attachmentkey to the basket selection panel #923

Closed gacarrillor closed 3 months ago

gacarrillor commented 3 months ago

…, so that it's easier to identify them.

Requires: https://github.com/opengisch/QgisModelBakerLibrary/pull/100

Fix #600

gacarrillor commented 3 months ago

@signedav, before merging this, please have a look at the last commit and let me know if it's good for you. See: https://github.com/opengisch/QgisModelBaker/issues/600#issuecomment-2163382402

signedav commented 3 months ago

I think I would have preferred to pass an argument to the dialog (not a context maybe, but just a bool like basket_integration or similar) but I guess it's fine like this as well. Good work!

gacarrillor commented 3 months ago

I think I would have preferred to pass an argument to the dialog (not a context maybe, but just a bool like basket_integration or similar) but I guess it's fine like this as well. Good work!

Yeap, that would be better indeed. Applied in https://github.com/opengisch/QgisModelBaker/pull/923/commits/62a644a9f7665064bdb3d1a7232a5479d315d291, thanks!

signedav commented 3 months ago

Oups. Just noticed there is in fact already such a parameter: wizard_embedded

gacarrillor commented 3 months ago

Oups. Just noticed there is in fact already such a parameter: wizard_embedded

Ouch, should I open another PR to use wizard_embedded instead?

signedav commented 3 months ago

yes. sorry, I haven't seen it before.

gacarrillor commented 3 months ago

yes. sorry, I haven't seen it before.

No problem, I also overlooked it. Done in https://github.com/opengisch/QgisModelBaker/pull/934