search

opengisch / QgisModelBaker

Create QGIS projects from database schemas or Interlis models
https://opengisch.github.io/QgisModelBaker/
GNU Lesser General Public License v3.0
55 stars 17 forks source link

Show warning message in TID manager when OIDs cannot be found #954

Closed gacarrillor closed 3 months ago

gacarrillor commented 3 months ago

Fix #925

image

signedav commented 3 months ago

Code looks good but I wonder if a message box would be nicer. This Warning Bar for me looks like an error and not like an information that it does not make sense to use this dialog. Maybe just grayed out everything makes sense as well.

gacarrillor commented 3 months ago

Code looks good but I wonder if a message box would be nicer. This Warning Bar for me looks like an error and not like an information that it does not make sense to use this dialog. Maybe just grayed out everything makes sense as well.

I'll try with a message box to let the user know why the dialog is grayed out.

gacarrillor commented 3 months ago

@signedav, BTW, yesterday I think I finally did it with a message bar because I saw we had this message for a similar case in the Dataset Manager (i.e., empty project, probably first time opening Model Baker dialogs):

image

Should we bring a message box also for this Dataset Manager or we leave it as is and implement a message box for the OID Manager anyways?

signedav commented 3 months ago

Hm... Looks cleaner when we only have one row. So less strong opinion meanwhile. What is your opinion? Both box or both bar?

gacarrillor commented 3 months ago

Hm... Looks cleaner when we only have one row. So less strong opinion meanwhile. What is your opinion? Both box or both bar?

I'd prefer both with message bars, although I agree, it looks a bit overwhelming when we have more than one line. Perhaps we can rephrase it to make it fit into one line. The "Warning:" title could also be dropped to save space.

Another attempt (not sure it that will fit, apparently I have my verbose mode activated): To use the OID Manager, first configure a connection to an Interlis database in the Import/Export Wizard.

If you have a shorter alternative, please let me know.

signedav commented 3 months ago 
To use the OID Manager, configure a connection to an INTERLIS based database.
gacarrillor commented 3 months ago 
To use the OID Manager, configure a connection to an INTERLIS based database.

Thanks, screenshot updated and changes applied.