search

opengisch / pum

Postgres Upgrades Manager
GNU General Public License v2.0
30 stars 7 forks source link

do not sort deltas according to their type but their priority #50

Closed 3nids closed 5 years ago

elemoine commented 5 years ago

@3nids I'd be interested to understand the reason of this change. Why did you introduce the notion of priority? What did not work with the (version, type, name) ordering that we had before? It seems to me that this change does not actually change the ordering so I'd be interested to understand if it fixes an actual problem. Thanks.

3nids commented 5 years ago

There a 4 implicit ordering which was the type of delta (sql vs py). With this, the ordering isn't influenced by the type of delta and respect the name ordering.

elemoine commented 5 years ago

Ok I see. That makes sense. In that case I think we should slightly change the documentation because it currently suggests that the py deltas are executed before the sql deltas. If you agree I'll make changes to the readme.