opengisch / qgis-plugin-ci

Let it package and release your QGIS plugin and do something funnier instead!
https://opengisch.github.io/qgis-plugin-ci/
GNU General Public License v3.0
52 stars 17 forks source link

Why not Python 3.6? #25

Closed ismailsunni closed 4 years ago

ismailsunni commented 4 years ago

Hi! I am curious, why is the minimum python version is 3.7? and will it be hard to make it work with python 3.6? Thanks :)

*sorry, since it's a question, not a bug report

Gustry commented 4 years ago

I can't remember why. I remember I got issues. Where do you have 3.6?

Just if you need it : https://hub.docker.com/repository/docker/etrimaille/qgis-plugin-ci

ismailsunni commented 4 years ago

On my Ubuntu 18.04, tried to upgrade to 3.7, but a lot of problems related to apt.

Ah, I also just finished creating Dockerfile for it a few minutes ago :D *very short anyway

Thanks, @Gustry!

Gustry commented 4 years ago

You can try to install on 3.6 in a virtualenv, but some functionalities will fail.

If you use docker with your custom image, you might hit issues about git config (username and email which are required for git stash).

Just showing our gitlab-ci file :

      docker run
      --rm -w /plugin
      -v ${CI_PROJECT_DIR}:/plugin
      -u $(id -u):$(id -g)
      etrimaille/qgis-plugin-ci:1.8.2
      package ${CI_COMMIT_REF_NAME}
      --allow-uncommitted-changes
      --disable-submodule-update
      --plugin-repo-url https://custom.server.url/

I will write a readme.

Gustry commented 4 years ago

Are you fine with my docker image? Can we close this one or do you plan to port it to 3.6 ?

ismailsunni commented 4 years ago

hi @Gustry , I ended up using a manual way since I got an error when running the push-translation. Because I can't debug it without docker, I gave up :) I think we can close this one.

Gustry commented 4 years ago

You can't use Travis or GitHub actions?

ismailsunni commented 4 years ago

I tried to run manually from my machine first (from terminal), but I got the error when running the push translation. So, I didn't try the Travis or Github one.

On Thu, Aug 20, 2020 at 8:12 AM Étienne Trimaille notifications@github.com wrote:

You can't use Travis or GitHub actions?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/opengisch/qgis-plugin-ci/issues/25#issuecomment-677252730, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK3EJM2RBLH2HHMULP34YDSBS5GBANCNFSM4PWVLOYQ .

-- Ismail Sunni Software Engineer ismailsunni.id ismailsunni.wordpress.com

Gustry commented 4 years ago

@ismailsunni I have fixed the docker image when pushing translations https://github.com/3liz/docker-qgis-plugin-ci/commit/2de63f8dc14a3ca181d727d4ad3563459df51aeb

And in this repo as well 59846e73a7c597cad0c5d740a2060ba8c26da299

ismailsunni commented 4 years ago

Thanks, @Gustry, hopefully, I can find a time to try :)