search

openglsuperbible / sb6code

Source code for OpenGL SupeBible 6th Edition examples
484 stars 177 forks source link

Are there plans to move to glfw3? #1

Open dangets opened 10 years ago

dangets commented 10 years ago

glfw3 changes quite a few of the api calls, but seems like they are moving away from the 2.x versions. Is there any development towards this? I don't mind forking and starting it, but just didn't want to overlap any current development.

Thanks! Danny G

dangets commented 10 years ago

Well, being bored, I modified the sb6.h header to use glfw3 on a branch. The code is in https://github.com/dangets/sb6code/tree/glfw3 if you're interested. note I did just the most basic porting - and no testing besides everything compiling and seeing the 'simple' examples work.

grahamsellers commented 10 years ago

Hi Danny,

I hadn't planned to make any more major changes to the framework code. I was aware that GLFW3 was released, even before the book shipped. However, this application framework is really simple and isn't really using much of the functionality of GLFW beyond opening the window and looking at key presses. I didn't see an advantage to changing the version and pushing out a new drop (along with all the testing that's required to say this is good). I'll take a look at your branch and maybe integrate it. Thanks for putting the effort in. I'm going to continue with GLFW for the next edition (which isn't even being planned yet), and I'll certainly grab the most recent edition when I put together the first few samples for that book.

Cheers,

Graham

On Mon, Nov 4, 2013 at 4:54 PM, Danny George notifications@github.comwrote:

Well, being bored, I modified the sb6.h header to use glfw3 on a branch. The code is in https://github.com/dangets/sb6code/tree/glfw3 if you're interested. note I did just the most basic porting - and no testing besides everything compiling and seeing the 'simple' examples work.

— Reply to this email directly or view it on GitHubhttps://github.com/openglsuperbible/sb6code/issues/1#issuecomment-27726524 .

jeremyong commented 10 years ago

My 2 cents. If you don't plan on upgrading the GLFW version the code expects, include it as a submodule and link to it locally. People who develop with GLFW or have GLFW installed as a dependency on their system have to go out of their way to build this code.

jeremyong commented 10 years ago

I see that it's in the extern folder now. It'd be nice if cmake built it and linked to it.

gustavonmartins commented 8 years ago

Hello dangets. I hope you are still here with us :)

I just bought the book and I am having problems to compile since the first example... This is quite disappointing.

But anyway... I opened your modified sb6 file and I cant get it to compile. I get the error at line235 of your code: 'OutputDebugStringA' was not declared in this scope

I dont know how to fix it and I just opened a github account to inform you of that. It would be great if you could update your file to work :)

Just for your information,I am running windows 8.1 64 bits using codeblocks svn 10376 and GCC 5.2.0 that I got from msys2 (folder msys64/mingw64)

Thanks for your time!

Gustavo

dangets commented 8 years ago

Ha, I'm still here, but yeah this seems like it was ages ago. I'll see if I can spend some time on it in the near future. I'm running on Linux, but hopefully it wouldn't be too difficult to tweak any further issues to get it working on Windows.

sangwoo108 commented 5 years ago

As of now, I couldn't build examples on Windows as it is. So I roughly made a fix to use GLFW3. It's messy but I hope someone who studies this book can benefit from the fix.