Calls to glUniform*() wrongly assume uniform variable is at location 0 - Githubissues

openglsuperbible / sb7code

Source code and supporting material for the 7th Edition of OpenGL SuperBible

727 stars 251 forks source link

Calls to glUniform*() wrongly assume uniform variable is at location 0 #7

Open georgeraraujo opened 9 years ago

georgeraraujo commented 9 years ago

These changes fix problems on 4 of the examples (see below) with the following hardware & drivers on Windows 8.1 Pro x64:

NVIDIA GeForce GTX 650 Ti with driver 353.30
Intel HD 4400 with driver 10.18.14.4206 (OpenGL 4.3)

hdrexposure

NVIDIA: no output, and the following error: GL_INVALID_OPERATION error generated. Wrong component type or count.

ktxview

NVIDIA: GL_INVALID_OPERATION error generated. Wrong component type or count.
Intel: no output, and the following error: Error has been generated. GL error GL_INVALID_OPERATION: GL error GL_INVALID_OPERATION: mismatched type setting uniform "s" in program 1, "" using shaders, 2, "", 3, ""

tesssubdivmodes

NVIDIA: no output, and the following error: GL_INVALID_OPERATION error generated. Wrong component type or count.

wrapmodes

NVIDIA: wrong output, and the following error: GL_INVALID_OPERATION error generated. Wrong component type or count.

Wrong: wrapmodes_location0 Right: wrapmodes_glgetuniformlocation

mattgruenke commented 6 years ago

Thanks for this.

BTW, in my fork, I'm porting these examples to use OGLplus.