opengm
commented
10 years ago Hi! For us it works if MRF is before GCO, but you are right that there are potential pitfalls that we should fix.
As You have seen we already fix these libraries to get them work in a general software framework. However we try to modify as less as possible at the code of others.
The best solution in my mind would be to include
include "GCO-v3.0.src-patched/GCoptimization.h"
instead of
include "GCoptimization.h"
in our wrapper gco.hxx.
Since we are planning to restructure the downloading, compiling, and installing (later does not work yet) for external libraries any way, I would suggest to try the order MRF before GCO for the moment. If this does not work please let me know and I will add an hot-fix.
By the way, a small example would help us. We can add it to the test-suit to check if this is fixed after this re-factoring.
Best Joerg
On 11/27/2013 02:01 AM, Toru Tamaki wrote:
Because MRF-lib and GCO has different "GCoptimization.h" (same name, but different), I receive a lot of errors (depending of header path order) when I include the following headers in the same cpp file:
include
include
Possible solutions are:
- rename GCO/GCoptimization.h to something
- rename MRF/GCoptimization.h to something
- and make a corresponding patch, or write some lines of shell script to add
- or, do not recommend to use both at the same time
A patch renaming a file may be too large. Renaming file with a small patch might be better.
— Reply to this email directly or view it on GitHub https://github.com/opengm/opengm/issues/176.
tttamaki
joergkappes
Because MRF-lib and GCO has different "GCoptimization.h" (same name, but different), I receive a lot of errors (depending of header path order) when I include the following headers in the same cpp file:
include <opengm/inference/external/gco.hxx>
include <opengm/inference/external/mrflib.hxx>
Possible solutions are:
A patch renaming a file may be too large. Renaming file with a small patch might be better.