opengoofy / hippo4j

📌 异步线程池框架,支持线程池动态变更&监控&报警,无需修改代码轻松引入。Asynchronous thread pool framework, support Thread Pool Dynamic Change & monitoring & Alarm, no need to modify the code easily introduced.
https://hippo4j.cn
Apache License 2.0
5.48k stars 1.16k forks source link

修复:相同租户不同项目下,相同线程池id无法同时注册问题 #1526

Closed xx-ee closed 8 months ago

xx-ee commented 9 months ago

Fixes #1525 现象:

94bd73d724573ce808aab665add0515f

server端控制台一直报错如下: image

前提: 数据库config表:只存在1条记录:租户:hudong、项目id:hd-feed-ext-service-test、线程池id:feed-rednum-push-bath image

步骤:

  1. 启动第一个服务:租户:hudong、项目id:hd-feed-ext-service-test、线程池id:feed-rednum-push-bath,服务启动成功
  2. 启动第一个服务:租户:hudong、项目id:hd-feed-ext-service-dev、线程池id:feed-rednum-push-bath,服务启动失败,如图: 94bd73d724573ce808aab665add0515f

改动点:

  1. 二次检查添加config表信息时,与首次检查查询维度相同:租户、项目id、线程池id
codecov[bot] commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1e81da1) 34.33% compared to head (b8a96e6) 34.29%.

Files Patch % Lines
...o4j/config/service/biz/impl/ConfigServiceImpl.java 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1526 +/- ## ============================================= - Coverage 34.33% 34.29% -0.05% + Complexity 849 848 -1 ============================================= Files 262 262 Lines 5953 5955 +2 Branches 561 561 ============================================= - Hits 2044 2042 -2 - Misses 3717 3721 +4 Partials 192 192 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

magestacks commented 8 months ago

A more detailed test plan is needed, this PR is closed