search

opengovernment / askthem

Monitor and interact with local governments in the United States
GNU Affero General Public License v3.0
41 stars 15 forks source link

box height on question-recipient target selection #114

Closed davidmooreppf closed 11 years ago

davidmooreppf commented 11 years ago

On question creation pages :: http://oglocal.herokuapp.com/ny/questions/new?type=Person

... sometimes the box heights vary for senators & reps, e.g. ::

http://cl.ly/image/0z3K3Y2f1v0u

cc @walter - ideal is to display two senators next to each other on top row of two boxes, with US rep in box below on the left.

Is this an issue for Walter, in terms of the length of the elected official names & titles? Realize it's a bit tricky.

walter commented 11 years ago

Hmm. I think we are talking about two separate issues here:

I would like to deal with the sorting in a separate issue. It's a bit tricky.

As far as the box height, it definitely needs to be dealt with somehow. @acacheung, what do you think?

acacheung commented 11 years ago

@walter I'm not sure how this people list is getting rendered. It should have equal height li's, but what I think is happening is that the javascript is running before the list is getting loaded in. We can chat about this later if you have time.

walter commented 11 years ago

Code in question is here:

https://github.com/opengovernment/opengovernment-app/blob/master/app/assets/javascripts/questions.js.coffee#L117-L164

walter commented 11 years ago

Closing this now that #121 is open to handle sorting by office held.