Closed maryamgunja closed 10 years ago
So in /questions/show, I see <%= twitter_question_share( in line 140, and the copy for email sharing subject in 152, but I don't know if I see the place to change it where Q status is answered. Little help @walter?
This functionality requires some additional logic added to it.
I'm planning on doing this today. Will close this when it is done and let you know when it is deployed.
We should probably go through each sharing piece of text.
Here's what we have now for mail:
https://github.com/opengovernment/askthem/blob/master/app/helpers/questions_helper.rb#L44-L56
Here's what we have for Twitter:
https://github.com/opengovernment/askthem/blob/master/app/helpers/questions_helper.rb#L44-L56
(hopefully you can get the gist of the programming)
For Facebook and Google+, we can't do much unfortunately for long convoluted reasons.
Revised Sharing Copy -
Current:
Support my question to @TexGov on @AskThemPPF: Why are we subsidizing oil companies for stealing our resources and polluting our air, land and wate http://www.askthem.io/tx/questions/532712b3d535cfa1dd00004b
Change to:
Share (name/handle of official's) answer on @AskThemPPF to "(question title)" (Question)URL
FB
Current:
Ask Rick Perry: "Why are we subsidizing oil companies for stealing our resources and polluting... www.askthem.io Click to support this question on AskThem.io and get a public response.
Change to:
Share (name/handle of official's) answer to: "(question title)" www.askthem.io Click to support this answer on AskThem.io.
Google +
Current: Ask Rick Perry: "Why are we subsidizing oil companies for stealing our resources and polluting our air, land and wate" - Texas - AskThem.io
Change to:
Share (name/handle of official's) answer: "(question title)" - (State)- Askthem.io
On Thu, Mar 20, 2014 at 6:47 PM, Walter McGinnis notifications@github.comwrote:
We should probably go through each sharing piece of text.
Here's what we have now for mail:
https://github.com/opengovernment/askthem/blob/master/app/helpers/questions_helper.rb#L44-L56
Here's what we have for Twitter:
https://github.com/opengovernment/askthem/blob/master/app/helpers/questions_helper.rb#L44-L56
(hopefully you can get the gist of the programming)
For Facebook and Google+, we can't do much unfortunately for long convoluted reasons.
Reply to this email directly or view it on GitHubhttps://github.com/opengovernment/askthem/issues/395#issuecomment-38230453 .
...with capped twitter characters on copy to 60 instead of 100 (current)
On Thu, Mar 20, 2014 at 6:52 PM, Maryam Gunja maryam@askthem.io wrote:
Revised Sharing Copy -
Current:
Support my question to @TexGov on @AskThemPPF: Why are we subsidizing oil companies for stealing our resources and polluting our air, land and wate http://www.askthem.io/tx/questions/532712b3d535cfa1dd00004b
Change to:
Share (name/handle of official's) answer on @AskThemPPF to "(question title)" (Question)URL
FB
Current:
Ask Rick Perry: "Why are we subsidizing oil companies for stealing our resources and polluting... www.askthem.io Click to support this question on AskThem.io and get a public response.
Change to:
Share (name/handle of official's) answer to: "(question title)" www.askthem.io Click to support this answer on AskThem.io.
Google +
Current: Ask Rick Perry: "Why are we subsidizing oil companies for stealing our resources and polluting our air, land and wate" - Texas - AskThem.io
Change to:
Share (name/handle of official's) answer: "(question title)" - (State)- Askthem.io
On Thu, Mar 20, 2014 at 6:47 PM, Walter McGinnis <notifications@github.com
wrote:
We should probably go through each sharing piece of text.
Here's what we have now for mail:
https://github.com/opengovernment/askthem/blob/master/app/helpers/questions_helper.rb#L44-L56
Here's what we have for Twitter:
https://github.com/opengovernment/askthem/blob/master/app/helpers/questions_helper.rb#L44-L56
(hopefully you can get the gist of the programming)
For Facebook and Google+, we can't do much unfortunately for long convoluted reasons.
Reply to this email directly or view it on GitHubhttps://github.com/opengovernment/askthem/issues/395#issuecomment-38230453 .
@davidmooreppf & @maryamgunja this is now in place on the live site.
Note that FB & Google+ text is a bit different, but does indicate there is an answer rather than call for signatures.
When a question is answered change the sharing copy on FB/Twitter to reflect answer rather than to encourage signatures...
Current: