opengovfoundation / madison

Madison is a platform for lawmakers to share legislation with their citizens, allowing the community to add comments and suggest improvements.
GNU General Public License v3.0
677 stars 108 forks source link

Group validation needs some love #1047

Closed sethetter closed 7 years ago

sethetter commented 8 years ago

Currently validation happens in a single validate() method on the Group model. We are moving to a pattern of using Form Request objects for validation and authorization.

Furthermore, group related routes do not utilize model binding, but they should.

Furthermore, we should remove any extra single attribute update routes and consolidate into the single update route and contain conditional logic in the Form Request object for authorization and validation rules.

Lastly, the client will need updated to only use this new and improved update route.

doshitan commented 7 years ago

This is resolved in v4.