opengovfoundation / madison

Madison is a platform for lawmakers to share legislation with their citizens, allowing the community to add comments and suggest improvements.
GNU General Public License v3.0
674 stars 108 forks source link

Add annotation social shares #195

Open cmbirk opened 10 years ago

cmbirk commented 10 years ago

@bryanconnor would you check out this plugin:

http://danielcebrian.com/share-annotation/demo.html

And offer some feedback?

bryanconnor commented 10 years ago

Looks exactly the same as Annotator to me. They're even using the same image assets. The only difference I see is the share options.

cmbirk commented 10 years ago

It is Annotator. They're using a social plugin to Annotator. What do you think about the way the social plugin is implemented?

bryanconnor commented 10 years ago

Gotcha!

Well in that case I think the share icon itself is oversized, the modal window needs some styling (pretty sparse) but I'm glad it just outputs a url at the bottom as well because that's what I'd use 99% of the time.

My general concern is adding another icon to the annotator window along with like, dislike, flag, comments toggle, etc. I need to work on how to structure the information in the annotator window. It's a little disjointed right now. Where do I find the markup for that widget?

cmbirk commented 10 years ago

Editing Annotator is a bit trickier than just using a template. If you want to wireframe possible views for that, I can take a look at how to implement those.

On Apr 3, 2014, at 12:02 PM, Bryan notifications@github.com wrote:

Gotcha!

Well in that case I think the share icon itself is oversized, the modal window needs some styling (pretty sparse) but I'm glad it just outputs a url at the bottom as well because that's what I'd use 99% of the time.

My general concern is adding another icon to the annotator window along with like, dislike, flag, comments toggle, etc. I need to work on how to structure the information in the annotator window. It's a little disjointed right now. Where do I find the markup for that widget?

— Reply to this email directly or view it on GitHub.

bryanconnor commented 10 years ago

Will do.

bryanconnor commented 10 years ago

So to recap are these the elements the annotator window must have?

I'd like to challenge having tags and the close button. How do you want people to use tags? It feels like something that annotator can do but not something we need to do. The close button seems redundant as well since its all on hover.

cmbirk commented 10 years ago

The edit and close are gone now. It's not a close button, it's a delete button, but we aren't allowing users to delete or edit annotations.

bryanconnor commented 10 years ago

What do you think about tags? What's the value of that feature for annotations and for Madison?

cmbirk commented 10 years ago

Users definitely need to be able to tag their posts.  That will allow the legislators to filter them and we'll eventually add a front end filter for that as well.- Chris

On Tue, Apr 8, 2014 at 1:32 PM, Bryan notifications@github.com wrote:

What do you think about tags? What's the value of that feature for annotations and for Madison?

Reply to this email directly or view it on GitHub: https://github.com/opengovfoundation/madison/issues/195#issuecomment-39877559

bryanconnor commented 10 years ago

I put together some wireframes for the ideal setup of annotator. Bringing all of these feaure icons into the same language and layout will really help (including replies). To avoid icon confusion I also think we should remove the icon from the upper right of activity items. All of these changes would be made in the sidebar as well to bring these features into total alignment (i.e. the reply field is revealed when the comments are toggled).

annotator-01

cmbirk commented 10 years ago

I like those at first glance, although I think that share icon is probably trademarked by sharethis. We can probably use the one provided with Bootstrap though.

I do think we'll want to keep comments differentiated from annotations somehow, and I don't mind the way the icons do that at the moment. We may just want to add a legend or tooltips.

Annotator 2.0 is going to work towards decoupling the UI from the core of Annotator. That being said, the socials and below are doable before then.

@bryanconnor, what does it look like when a user clicks ( or hovers ) the share icon?

bryanconnor commented 10 years ago

I was hoping we could differentiate with text e.g. "bryanconnor commented" "chrisbirk annotated" and reserve the icons for actions (comment, like, dislike, flag, share).

I'll work on a view for sharing. I assume we're basing that on the demo above?

bryanconnor commented 10 years ago

We can display something like this in a modal like in the demo.

annotator-01

cmbirk commented 10 years ago

I would like to stay away from modals as much as possible, but if that's the only way we can think of...- Chris

On Wed, Apr 9, 2014 at 12:23 PM, Bryan notifications@github.com wrote:

We can display something like this in a modal like in the demo.

annotator-01

Reply to this email directly or view it on GitHub: https://github.com/opengovfoundation/madison/issues/195#issuecomment-39984589

bryanconnor commented 10 years ago

Nope I have a few other ideas that would be more tightly integrated with the annotation window. Just following the demo. Let me whip some of those up.

bryanconnor commented 10 years ago

What about something more integrated into the annotation window?

annotator-01