search

opengovsg / CheckWho

Enable Singapore residents to easily and authoritatively verify public officers
0 stars 0 forks source link

refactor: clean up hard-coded frontend styles #319

Open austinwoon opened 2 years ago

austinwoon commented 2 years ago

Problem

There are a ton of hardcoded styles in our frontend. Some examples include:

This makes it hard for us to make changes to styles which will apply to all existing components

Solution

Clean up all hardcoded styles and have a global style config (with responsive breakpoints) the whole application can refer to. This will not only save time in updating styles, but also developers time for developing features as there are a standardised set of styles to use.

Can be part of #318

austinwoon commented 2 years ago

Can extend theme ts file introduced in https://github.com/opengovsg/CheckWho/pull/320 @tan-zx