fix(attachment): convoy separation (#7449) - Githubissues

opengovsg / FormSG

Form builder for the Singapore Government

https://form.gov.sg

Other

260 stars 78 forks source link

fix(attachment): convoy separation (#7449) #7451

Closed KenLSM closed 2 weeks ago

KenLSM commented 2 weeks ago

New

fix(attachment): convoy separation #7449
build: release v6.130.0 #7441

Tests

@kevin9foong Regression on large submissions >10 crossing two convoys

[x] Create 40 submissions with 20 attachments
[x] Ensure that Download CSV (without attachment) returns 1 .csv file
[x] Ensure that Download CSV with attachment returns 40 .zip and 1 .csv file

Regression on small submissions < 10

[x] Create 7 submissions with 3 attachments only 1 convoy
[x] Ensure that Download CSV (without attachment) returns 1 .csv file
[x] Ensure that Download CSV with attachment returns 7 .zip and 1 .csv file

kevin9foong commented 2 weeks ago

lgtm and this is a really awesome fix!

ran the tests and verified that the # downloads is as expected.