This issue was discussed with @LoneRifle in person, and I would like to contribute to the i18n efforts in FormSG. This first PR involves the addition of en-sg translations for AdminFormNavbar to replace hardcoded string values.
Solution
This PR replaces hardcoded string values in AdminFormNavbar. The directories involved are frontend/src/features/admin-form/common/components/AdminFormNavbar and frontend/src/i18n/locales/features.
Breaking Changes
[ ] Yes - this PR contains breaking changes
Details ...
[x] No - this PR is backwards compatible
Features:
NA
Improvements:
A new directory has been created for the locale files and can be found at frontend/src/i18n/locales/features/admin-form-navbar.
Hardcoded values in AdminFormNavbar.tsx have been replaced with the corresponding translations.
Bug Fixes:
NA
Before & After Screenshots
BEFORE:
AFTER:
Tests
All tests as these changes involve the external facing UI.
Problem
This issue was discussed with @LoneRifle in person, and I would like to contribute to the i18n efforts in FormSG. This first PR involves the addition of en-sg translations for
AdminFormNavbarto replace hardcoded string values.Solution
This PR replaces hardcoded string values in
AdminFormNavbar. The directories involved arefrontend/src/features/admin-form/common/components/AdminFormNavbarandfrontend/src/i18n/locales/features.Breaking Changes
Features:
Improvements:
frontend/src/i18n/locales/features/admin-form-navbar.AdminFormNavbar.tsxhave been replaced with the corresponding translations.Bug Fixes:
Before & After Screenshots
BEFORE:
AFTER:
Tests
All tests as these changes involve the external facing UI.
Deploy Notes
NA
New environment variables:
NA
New scripts:
NA
New dependencies:
NA
New dev dependencies:
NA