feat: add myinfo child field for encrypt form - Githubissues

opengovsg / FormSG

Form builder for the Singapore Government

https://form.gov.sg

Other

270 stars 81 forks source link

feat: add myinfo child field for encrypt form #7471

Closed g-tejas closed 1 month ago

g-tejas commented 3 months ago

This mockpass persona has a child: S9912374E

Problem

Two issues

SGID with MyInfo doesn't have children field
Webhooks doesn't work with compound field (child field)

This PR enables it for encrypt forms.

Look at https://github.com/opengovsg/FormSG/pull/6447

Closes FRM-1520

One child field:

Screenshot 2024-07-04 at 2 32 18 PM

Multiple children added:

Screenshot 2024-07-04 at 2 35 39 PM

Breaking Changes

[x] No - this PR is backwards compatible

Tests

[ ] 1. Create a storage mode form
[ ] 2. Enable Singpass with MyInfo (not SGID)
[ ] 3. Add webhook to the form
[ ] 4. Make form public and make a submission
[ ] 5. Check that webhook has been triggered with the children information

linear[bot] commented 3 months ago

FRM-1520 Format Myinfo child response in storage-mode (webhook, response page, CSV download)