feat: remove extra whoami call for public checker page - Githubissues

opengovsg / checkfirst

Don't Know? CheckFirst. A tool to build eligibility checkers and calculators for Singapore Government policies

https://checkfirst.gov.sg

Other

11 stars 6 forks source link

feat: remove extra whoami call for public checker page #1102

Closed lamkeewei closed 2 years ago

lamkeewei commented 2 years ago

Problem

Public checker page should not require a call to /whoami.

Solution

Features:

Remove /whoami call on public checker page

Others

Manually excluded frontend dependencies in serverless.yml. This is not ideal and should be tackled through addressing issues #1103

Tests

[ ] Verify that public checker page still works as expected and /whoami is not called
[ ] Verify that logged in user should still get redirected to /dashboard when navigating to landing page
[ ] Non-existent URLs should still get redirected to the landing page
[ ] Navigation through the dashboard still still work as expected