opengovsg / checkfirst

Don't Know? CheckFirst. A tool to build eligibility checkers and calculators for Singapore Government policies
https://checkfirst.gov.sg
Other
11 stars 6 forks source link

fix: fix OGP Footer to show year dynamically and text in black #1258

Closed zxt-tzx closed 2 years ago

zxt-tzx commented 2 years ago

Problem

Right now, the footer has two problems:

Solution

As part of installing a new dependency, it seems like the package-lock.json has been significantly changed; I'm not sure whether there's any issues with that (what I did was to run npm ci per the instructions in the README, then npm i date-fns-tz.

More generally, how do I know whether I'm updating package-lock.json correctly when adding a new dependency? I have encountered situations where I clone a new codebase, do npm i and have a changed package-lock.json — I often wonder if it's because I did sth wrong during the setup or if it's because the previous package-lock.json is outdated hmm.

Before & After Screenshots

BEFORE: SCR-20220228-ic4

AFTER: SCR-20220228-ibz