feat: improve validation for OtpForm and LoginForm

opengovsg / checkfirst

Don't Know? CheckFirst. A tool to build eligibility checkers and calculators for Singapore Government policies

https://checkfirst.gov.sg

Other

11 stars 6 forks source link

Open zxt-tzx opened 2 years ago

zxt-tzx commented 2 years ago

While working on https://github.com/opengovsg/CheckWho/pull/251, thought to transpose the code changes to checkfirst.

Advantages:

More stringent frontend validation for email; must be @.gov.sg email, and not just any email
Error case looks more aesthetic using react-hook-form and Chakra UI's FormControl, compared to default HTML

BEFORE: SCR-20220414-uqh

AFTER: SCR-20220414-st9