fix: delete the correct condition instead of the last one #1266 - Githubissues

opengovsg / checkfirst

Don't Know? CheckFirst. A tool to build eligibility checkers and calculators for Singapore Government policies

https://checkfirst.gov.sg

Other

12 stars 6 forks source link

fix: delete the correct condition instead of the last one #1266 #1277

Closed aniruddha-adhikary closed 2 years ago

aniruddha-adhikary commented 2 years ago

Problem

Closes #1266

Solution

I just used the passed the ID of a Condition as the key, instead of the index.

Bug Fixes:

Deletes the correct entry from Conditions, when the corresponding trash icon is clicked.

Before & After Screenshots

BEFORE: before

AFTER: after

Tests

What tests should be run to confirm functionality?

Deploy Notes

Notes regarding deployment of the contained body of work. These should note any new dependencies, new scripts, etc.

New environment variables:

env var : env var details

New scripts:

script : script details

New dependencies:

dependency : dependency details

New dev dependencies:

dependency : dependency details