search

opengovsg / design-system

The Design System used at Open Government Products
https://design.open.gov.sg
37 stars 11 forks source link

[BUG] Modal components have wrong padding #447

Open seaerchin opened 1 year ago

seaerchin commented 1 year ago

Describe the bug Modal components have padding that does not adhere to the figma.

To Reproduce Steps to reproduce the behavior:

  1. create a barebones Modal with the following components: modal content, button, header, footer
  2. Observe that ModalCloseButton, ModalFooter and ModalHeader have wrong padding.

Expected behavior The padding should be correct

NatMaeTan commented 1 year ago

Piggybacking on this issue,

  1. Close icon is also inconsistent with figma, looks skinnier than our boxicon

  2. Clear 'Cancel' button should be in the neutral variant, currently is in brand colors

Per chin's comment, Footer padding should be 40px above and below the button group