opengovsg / pdf2md

A PDF to Markdown converter
https://www.npmjs.com/package/@opendocsg/pdf2md
MIT License
195 stars 39 forks source link

CompactLines: Refrain from generating JSX links #26

Closed LoneRifle closed 5 years ago

LoneRifle commented 5 years ago

The transformation steps embed messages in ParseResult mostly for use in DebugView, where they are displayed to the user. CompactLines puts in JSX elements, which require React. This has to be removed so that lib/ can be made into pure JS.

Knock out the aforementioned logic, limiting CompactLines' messages to reporting how many footnotes are generated, not links that jump to the page containing the footnotes.

Correct flow annotation for LineConverter whilst we are here