opengovsg / postmangovsg

Templated message sending for public officers
https://postman.gov.sg
60 stars 16 forks source link

fix(backend): account message.eventType for blacklisting emails #2182

Closed stanleynguyen closed 1 year ago

stanleynguyen commented 1 year ago

Problem

We switched to using only events from SNS instead of native events from SES. There's a discrepancy which is the prior one uses eventType field name while the latter uses notiticationType

Solution

Use both fields to determine the notification type in blacklisting

Deployment Checklist

Any tasks that need to be done on the environment before releasing of this PR (e.g. Setting environment variables, running migrations, etc). If there's no task to be done, put "N/A"