search

opengovsg / sgid-client

The official TypeScript/JavaScript SDK for sgID
MIT License
11 stars 6 forks source link

Update SDK to reference `well-known` endpoint #41

Closed raynerljm closed 1 year ago

raynerljm commented 1 year ago

Currently, the SDK is constructing its own values for the necessary endpoints

Image

Update the SDK to reference the well-known endpoint according to the OpenID Discovery RFC

kwajiehao commented 1 year ago

From our offline discussion:

Jie Hao: "if our SDK references the well-known endpoint, this means that our SDK will need to make an extra API call which adds more latency for the RP app. I'm not sure if this tradeoff (extra latency for correctness of OIDC endpoints) is worth it given that we control both the SDK and the API server"

kwajiehao commented 1 year ago

Closing this issue because there's no urgent need for us to use the well-known endpoint in our SDK as our team is small and develops all products involved