refactor: improve file button typing

opengovsg / starter-kit

A technical kit to quickly build new products

https://start.open.gov.sg

MIT License

39 stars 7 forks source link

refactor: improve file button typing #187

Closed dextertanyj closed 1 year ago

dextertanyj commented 1 year ago

This PR improves the type safety of the FileButton component by removing the use of TypeScript generics and replacing it the use of discriminated unions.

As a result, TypeScript correctly infers the onChange and append variables based on the value of multiple and forwardRef correctly returns the type of the component since no generics are involved

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
starter-kit	✅ Ready (Inspect)	Visit Preview	Aug 18, 2023 9:33am