search

opengribs / XyGrib

This is the new home for the development of zyGrib
https://opengribs.org
GNU General Public License v3.0
120 stars 47 forks source link

Area selection for download needs minimum size enforcement #151

Closed norulz closed 5 years ago

norulz commented 5 years ago

Now that we added decimals to the degrees defining the rectangle it is possible to select an area that is small enough not to have a grid data point in it. The Grib Sever fails and returns "Bad Request".

Min size enforcement is needed.

norulz commented 5 years ago

Fixed in v1.2.2

norulz commented 5 years ago

This still appears to be an issue

did-g commented 5 years ago

Hi, Have you any area size sample showing this issue?

Didier

On Sun, Oct 20, 2019 at 11:40 AM David Gal notifications@github.com wrote:

This still appears to be an issue

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/opengribs/XyGrib/issues/151?email_source=notifications&email_token=AC4TMKTNPOPLXKIFWDNFHDTQPQRPNA5CNFSM4GFH7XBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBYGH5A#issuecomment-544236532, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4TMKREMJKRPUSVOM4E2R3QPQRPNANCNFSM4GFH7XBA .

norulz commented 5 years ago

Hi Didier, Here is the example that was posted in the support forum. Less than one degree in both axes. When the lat-lon numbers are rounded up to 1x1 degree a result is retreived.

David

image

did-g commented 5 years ago

Hi, Seems to me it could be a bug on the server side, xygirb request is: GET /getmygribs2.php?osys=ubuntu&ver=1.2.7&model=aromep025&la1=43&la2=43.75&lo1=5&lo2=5.75&intv=1&days=1&cyc=last&par=W;p;R;C;T;H;G;&wmdl=none&wpar= HTTP/1.1

On Mon, Oct 21, 2019 at 2:24 PM David Gal notifications@github.com wrote:

Hi Didier, Here is the example that was posted in the support forum. Less than one degree in both axes. When the lat-lon numbers are rounded up to 1x1 degree a result is retreived.

David

[image: image] https://user-images.githubusercontent.com/6072089/67204598-84718200-f416-11e9-8fc5-12b8f5bc83f1.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/opengribs/XyGrib/issues/151?email_source=notifications&email_token=AC4TMKV6ALBPC7AEOYVPN7LQPWNQDA5CNFSM4GFH7XBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB2EG5Y#issuecomment-544490359, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4TMKT2GRNF3EPXX7DWUHLQPWNQDANCNFSM4GFH7XBA .

norulz commented 5 years ago

You were correct. The server side was casting la1, la2... to int instead of float. At an earlier stage we were only using integers for the rectangle and I didn't update the servers side when we made the change.

It is now possible to request a rectangle less that one full degree. Thanks.