search

opengribs / XyGrib

This is the new home for the development of zyGrib
https://opengribs.org
GNU General Public License v3.0
120 stars 47 forks source link

Accumulation time range use the right unit #267

Closed did-g closed 3 years ago

did-g commented 3 years ago

Hi

P1 an P2 are in unitOfTimeRange unit, convert them to hour when computing.

Need testing but it should solve accumulation issue.

norulz commented 3 years ago

Hi, Something is wrong. I tested with a grib2 file and it is OK but with grib1 the precipitation values are too small by a factor of about 14. I have attached 2 identical grib files, one is grib1 and one is grib2. Check for Wed 23/12 1800z at POI 32° 5.82' N 034° 40.24' E. The value of 2.42 mm/h is the correct one.

2012220000_f000000_arw_d01.zip Crusade_12km_WRF_WAM_201222-00.zip

norulz commented 3 years ago

I updated the correct precipitation value NOT 7.24 but 2.42 mm/hr :-)

did-g commented 3 years ago

I'm not following here, it seems ok to me. Am I missing something?

norulz commented 3 years ago

Hi, Are you getting the same rates of precipitation in both of the grib files? The grib1 file was converted from the grib2. In 1.2.6 both show the same rate for 3 hours without correction for 1 hour of precipitation. In 1.2.;7 before the last PR the grib2 file was corrected for hourly rate but the grib1 was still showing accumulation for 3hours. In 1.2.7 after the last PR the grib2 file is OK but the grib1 shows very low values of precipitation. It appears that the rate calculation is being overly applied.