search

opengribs / XyGrib

This is the new home for the development of zyGrib
https://opengribs.org
GNU General Public License v3.0
120 stars 47 forks source link

Missing icon in certin context #271

Open FredericGuilbault opened 3 years ago

FredericGuilbault commented 3 years ago

Hi,

I'm porting lysmarine to awesomewm DE, and it use a software called rofi as menu.

In rofi, the icon specified by xygrib.desktop does not show. But if I remove the file extension for the icon. It fixes the problem :

sudo sed -i "s/xygrib.png/xygrib/g" /usr/share/applications/xygrib.desktop

I did the same on my Linux mint 20 and removing the file extension did not break it.

Should it be removed ?

FredericGuilbault commented 3 years ago

https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html

It's not explicit, but from reading those two specifications, The way I get it. it should be a full path to the file, or it's an icon name and not a file name. Then it's passed down to the theme manager.

https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html

There is an interesting part where it specifies to put the icons in the hicolor theme.

So, you're an application author, and want to install application icons so that they work in the KDE and Gnome menus. Minimally you should install a 48x48 icon in the hicolor theme. This means installing a PNG file in $prefix/share/icons/hicolor/48x48/apps. Optionally you can install icons in different sizes. For example, installing a svg icon in $prefix/share/icons/hicolor/scalable/apps means most desktops will have one icon that works for all sizes. You might even want to install icons with a look that matches other well known themes so your application will fit in with some specific desktop environment.