opengribs / XyGrib

This is the new home for the development of zyGrib
https://opengribs.org
GNU General Public License v3.0
120 stars 47 forks source link

build fails for openjpeg 2.4 #274

Open coogor opened 3 years ago

coogor commented 3 years ago

..the attached patch fixes the issue libjpeg24.txt

(Hm, why does github not allow uploads with extention .diff?)

gromain commented 3 years ago

Just so you know, we manage to build this package for Arch Linux with the following patch on CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index b066a04..0e286f2 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -116,7 +116,7 @@ find_path(OPENJPEG_INCLUDE_DIR
      /opt/local/include # DarwinPorts
      /opt/csw/include # Blastwave
      /opt/include
-     PATH_SUFFIXES openjpeg-2.3 openjpeg-2.2 openjpeg-2.1
+     PATH_SUFFIXES openjpeg-2.4 openjpeg-2.3 openjpeg-2.2 openjpeg-2.1
      REQUIRED
  )
 include_directories(${OPENJPEG_INCLUDE_DIR})

Source here: https://aur.archlinux.org/cgit/aur.git/tree/CMakelists.txt.patch?h=xygrib-git

gromain commented 3 years ago

Also, I thought you attached an error log.

Your patch works for version 1.2.6. Mine works for the latest git version.

coogor commented 3 years ago

Your patch works for version 1.2.6. Mine works for the latest git version.

Yes, thats the latest version :-)